docs: Enable auto logged in components on landing page #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcramer
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
documentation
cpcramer
commented
Dec 17, 2024
site/docs/components/AppDemo.tsx
Outdated
| const queryClient = new QueryClient(); | ||
|
|
||
| const demoWalletConnector = () => () => { | ||
| const demoWalletPK = import.meta.env.VITE_DEMO_WALLET_PK; |
There was a problem hiding this comment.
This demo wallet will never have a value associated with it therefore I believe it's fine to leak the PK in the client.
cpcramer
changed the title
cpcramer
force-pushed
the
paul/auto-logged-in-components
branch
from
21db9bb to
44675e1
Compare
dschlabach
reviewed
Dec 17, 2024
dschlabach
approved these changes
Dec 17, 2024
| @@ -61,10 +59,9 @@ function WalletDemo() { | |||
| Wallet | |||
| </WalletDropdownLink> | |||
| <WalletDropdownBasename /> | |||
| <WalletDropdownDisconnect /> | |||
There was a problem hiding this comment.
given that we are removing disconnect option, consider adding a warning like, "wallet address for demonstration purposes only. do not send funds to this address"
brendan-defi
approved these changes
Dec 17, 2024
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Create new demo app provider which includes our auto logged in demo wallet. This is to achieve a "logged in" state for our components on the landing page, allowing users to see the intended components rather than a bunch of Connect Wallet buttons.
For now, we are only auto logging in for the Wallet and Swap component. The Fund and Transaction component would have to be set to disabled. We've decided that it's better to leave these and allow the user to connect their own wallet to test out the functionality.
Notes to reviewers
How has it been tested?